Make user-defined repository parameter of ArtifactResolver constructor work#21
Open
ufolr wants to merge 2 commits intoairlift:masterfrom
Open
Make user-defined repository parameter of ArtifactResolver constructor work#21ufolr wants to merge 2 commits intoairlift:masterfrom
ufolr wants to merge 2 commits intoairlift:masterfrom
Conversation
Set the custom local and remote repository to the ProjectBuildingRequest when get pom's MavenProject.
Author
|
By doing this, we can make below Plugin Config property of presto work. maven.repo.local
maven.repo.remotePlease take a look @electrum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the local maven repo may not be
~/.m2/repository.And In my area, by some network reason we can't connect to the official maven repo, or the official repo is too slow to use. I have to use a mirror repo to speed up the downloading.
When I construct an ArtifactResolver Object with user-defined local repository and remote repository mirror, it can't resolve the pom.
Here is a full test code to replay the issue #20
I find this is because, in function MavenProject getMavenProject(File pomFile), it always use the default repository
So I make this PR to set the user-defined repositories to the
request, and I exchange the order of repositories handle to make sure the user-defined remote repository to use first.